Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and indentation in _queue.html.erb #11091

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix typos and indentation in _queue.html.erb #11091

merged 1 commit into from
Apr 21, 2022

Conversation

ayish1998
Copy link
Contributor

@ayish1998 ayish1998 commented Apr 21, 2022 •
edited
Loading

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Apr 21, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2022

Code Climate has analyzed commit 940aaf6 and detected 0 issues on this pull request.

View more on Code Climate.

@ayish1998
Copy link
Contributor Author

@TildaDares please check if this is what is expected of me?

@ayish1998
Copy link
Contributor Author

@TildaDares waiting for a review

@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #11091 (940aaf6) into main (4965b05) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11091      +/-   ##
==========================================
+ Coverage   82.33%   82.45%   +0.11%     
==========================================
  Files          98       98              
  Lines        5990     5990              
==========================================
+ Hits         4932     4939       +7     
+ Misses       1058     1051       -7
Impacted Files Coverage Δ
app/api/srch/search.rb 70.51% <0.00%> (+3.84%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

TildaDares
TildaDares approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ayish1998 for sticking with this.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6211148888/artifacts/219537938

@TildaDares TildaDares merged commit 18bc1dd into publiclab:main Apr 21, 2022
@welcome
Copy link

welcome bot commented Apr 21, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares TildaDares changed the title update_issue_#11009 Fix typos and indentation in _queue.html.erb Apr 21, 2022
@TildaDares TildaDares mentioned this pull request Apr 21, 2022
Closed
5 tasks
@TildaDares
Copy link
Member

Congratulations @ayish1998🎉

@ayish1998
Copy link
Contributor Author

Thank you @TildaDares for the guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TildaDares TildaDares TildaDares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayish1998 @TildaDares